Base-python: fix bug when reading schemas from shared/ folder
#3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zirochkaa
approved these changes
Apr 29, 2021
|
/publish connector=bases/base-python
|
sherifnada
changed the title
sherifnada
changed the title
shared/ folder
| @@ -38,8 +38,7 @@ def __init__(self, shared_schemas_path: str): | |||
|
|
|||
| @staticmethod | |||
| def _load_shared_schema_refs(shared_schemas_path: str): | |||
| shared_file_names = [f for f in os.scandir(shared_schemas_path) if f.isfile()] | |||
|
|
|||
| shared_file_names = [f.name for f in os.scandir(shared_schemas_path) if f.is_file()] | |||
There was a problem hiding this comment.
Any way you could have some unit tests for these?
There was a problem hiding this comment.
yes, top priority after refactoring the package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.