[don't merge] trigger test runs for refactor pr #31586

erohmensing · 2023-10-18T20:01:24Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Connector version is set to 0.0.1
- Dockerfile has version 0.0.1
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
- docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds then checking in your changes
Documentation which references the generator is updated as needed

Updating the Python CDK

Airbyter

Before merging:

Pull Request description explains what problem it is solving
Code change is unit tested
Build and my-py check pass
Smoke test the change on at least one affected connector
- On Github: Run this workflow, passing --use-local-cdk --name=source-<connector> as options
- Locally: airbyte-ci connectors --use-local-cdk --name=source-<connector> test
PR is reviewed and approved

After merging:

Publish the CDK
- The CDK does not follow proper semantic versioning. Choose minor if this the change has significant user impact or is a breaking change. Choose patch otherwise.
- Write a thoughtful changelog message so we know what was updated.
Merge the platform PR that was auto-created for updating the Connector Builder's CDK version
- This step is optional if the change does not affect the connector builder or declarative connectors.

vercel · 2023-10-18T20:01:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 18, 2023 10:19pm

erohmensing · 2023-10-18T20:01:33Z

Current dependencies on/for this PR:

master
- PR Update Pipelines folder structure #31525
  - PR [don't merge] trigger test runs for refactor pr #31586 👈

This comment was auto-generated by Graphite.

github-actions · 2023-10-18T20:01:49Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

…stpr

airbyte-oss-build-runner · 2023-10-18T22:01:37Z

source-faker test report (commit `f96893d61c`) - ❌

⏲️ Total pipeline duration: 43.54s

Step	Result
Build source-faker docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-faker	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

airbyte-oss-build-runner · 2023-10-18T22:10:20Z

source-stripe test report (commit `f96893d61c`) - ❌

⏲️ Total pipeline duration: 09mn26s

Step	Result
Build source-stripe docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-stripe	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

airbyte-oss-build-runner · 2023-10-18T22:19:43Z

source-mysql test report (commit `f96893d61c`) - ❌

⏲️ Total pipeline duration: 18mn49s

Step	Result
Build connector tar	✅
Java Connector Unit Tests	✅
Build source-mysql docker image for platform(s) linux/x86_64	✅
Acceptance tests	✅
Java Connector Integration Tests	✅
Validate metadata for source-mysql	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

…stpr

airbyte-oss-build-runner · 2023-10-18T22:24:44Z

source-faker test report (commit `da770da1b5`) - ❌

⏲️ Total pipeline duration: 02mn01s

Step	Result
Build source-faker docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-faker	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

airbyte-oss-build-runner · 2023-10-18T22:27:26Z

source-stripe test report (commit `da770da1b5`) - ❌

⏲️ Total pipeline duration: 05mn43s

Step	Result
Build source-stripe docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-stripe	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

airbyte-oss-build-runner · 2023-10-18T22:41:39Z

source-mysql test report (commit `da770da1b5`) - ❌

⏲️ Total pipeline duration: 19mn56s

Step	Result
Build connector tar	✅
Java Connector Unit Tests	✅
Build source-mysql docker image for platform(s) linux/x86_64	✅
Acceptance tests	✅
Java Connector Integration Tests	✅
Validate metadata for source-mysql	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

airbyte-oss-build-runner · 2023-10-18T22:45:27Z

destination-e2e-test test report (commit `da770da1b5`) - ❌

⏲️ Total pipeline duration: 03mn37s

Step	Result
Build connector tar	✅
Java Connector Unit Tests	✅
Build destination-e2e-test docker image for platform(s) linux/x86_64	✅
Java Connector Integration Tests	❌
Validate metadata for destination-e2e-test	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-e2e-test test

make some changes to trigger test runs

daed507

erohmensing mentioned this pull request Oct 18, 2023

Update Pipelines folder structure #31525

Merged

octavia-squidington-iii added area/connectors Connector related issues connectors/destination/e2e-test connectors/source/stripe connectors/source/mysql connectors/source/faker labels Oct 18, 2023

erohmensing changed the title ~~trigger test runs for refactor pr~~ [don't merge] trigger test runs for refactor pr Oct 18, 2023

erohmensing marked this pull request as ready for review October 18, 2023 20:02

erohmensing requested a review from a team as a code owner October 18, 2023 20:02

octavia-squidington-iv requested a review from a team October 18, 2023 20:03

erohmensing and others added 4 commits October 18, 2023 20:17

Automated Commit - Formatting Changes

c6d8879

Merge branch 'ella-ben/pipelines/refactor-folder-struct' into ella/te…

47c5a16

…stpr

Merge branch 'ella-ben/pipelines/refactor-folder-struct' into ella/te…

1b7f1d6

…stpr

Merge branch 'ella-ben/pipelines/refactor-folder-struct' into ella/te…

f96893d

…stpr

Automated Commit - Formatting Changes

adf26d7

Merge branch 'ella-ben/pipelines/refactor-folder-struct' into ella/te…

da770da

…stpr

erohmensing closed this Oct 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[don't merge] trigger test runs for refactor pr #31586

[don't merge] trigger test runs for refactor pr #31586

erohmensing commented Oct 18, 2023

vercel bot commented Oct 18, 2023 •

edited

Loading

erohmensing commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

airbyte-oss-build-runner commented Oct 18, 2023

airbyte-oss-build-runner commented Oct 18, 2023

airbyte-oss-build-runner commented Oct 18, 2023

airbyte-oss-build-runner commented Oct 18, 2023

airbyte-oss-build-runner commented Oct 18, 2023

airbyte-oss-build-runner commented Oct 18, 2023

airbyte-oss-build-runner commented Oct 18, 2023

[don't merge] trigger test runs for refactor pr #31586

[don't merge] trigger test runs for refactor pr #31586

Conversation

erohmensing commented Oct 18, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Airbyter

vercel bot commented Oct 18, 2023 • edited Loading

erohmensing commented Oct 18, 2023

github-actions bot commented Oct 18, 2023

Before Merging a Connector Pull Request

airbyte-oss-build-runner commented Oct 18, 2023

source-faker test report (commit f96893d61c) - ❌

airbyte-oss-build-runner commented Oct 18, 2023

source-stripe test report (commit f96893d61c) - ❌

airbyte-oss-build-runner commented Oct 18, 2023

source-mysql test report (commit f96893d61c) - ❌

airbyte-oss-build-runner commented Oct 18, 2023

source-faker test report (commit da770da1b5) - ❌

airbyte-oss-build-runner commented Oct 18, 2023

source-stripe test report (commit da770da1b5) - ❌

airbyte-oss-build-runner commented Oct 18, 2023

source-mysql test report (commit da770da1b5) - ❌

airbyte-oss-build-runner commented Oct 18, 2023

destination-e2e-test test report (commit da770da1b5) - ❌

vercel bot commented Oct 18, 2023 •

edited

Loading

source-faker test report (commit `f96893d61c`) - ❌

source-stripe test report (commit `f96893d61c`) - ❌

source-mysql test report (commit `f96893d61c`) - ❌

source-faker test report (commit `da770da1b5`) - ❌

source-stripe test report (commit `da770da1b5`) - ❌

source-mysql test report (commit `da770da1b5`) - ❌

destination-e2e-test test report (commit `da770da1b5`) - ❌