Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail sync when Debezium fails to shutdown properly #31674

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Fail sync when Debezium fails to shutdown properly #31674

merged 11 commits into from
Oct 24, 2023

Conversation

akashkulk
Copy link
Contributor

If debezium has not shutdown correctly, it can indicate an error with the connector configuration or a partial sync success. In situations like these, the preference is to fail loud and clear.

Reasoning behind this :

  1. In some cases, a silent failure causes the sync to appear to succeed (with 0 records) when it has actually failed : https://airbytehq-team.slack.com/archives/C043JHEEYKG/p1696637590900289
  2. In some cases, a silent failure creates a different exception unrelated to the actual failure reason : https://app.zenhub.com/workspaces/db--dw-source-connectors-6333360e0a41155061efbcbd/issues/gh/airbytehq/airbyte/31290

Reference to discussion in DBZ community : https://debezium.zulipchat.com/#narrow/stream/302529-community-general/topic/.E2.9C.94.20Invalid.20Connector.20configuration.20not.20throwing.20an.20exception

@vercel
Copy link

vercel bot commented Oct 20, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 10:05pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Oct 20, 2023
@akashkulk akashkulk marked this pull request as ready for review October 23, 2023 18:51
@akashkulk
Copy link
Contributor Author

akashkulk commented Oct 24, 2023 •
edited by github-actions bot

/publish-java-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/6629791551
✅ Successfully published Java CDK version=0.1.12!

@akashkulk
Copy link
Contributor Author

akashkulk commented Oct 24, 2023 •
edited by github-actions bot

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6630022321
❌ Publish Java CDK version=0.1.12 failed!

@akashkulk
Copy link
Contributor Author

akashkulk commented Oct 24, 2023 •
edited by github-actions bot

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6630316779
❌ Publish Java CDK version=0.1.12 failed!

@akashkulk
Copy link
Contributor Author

akashkulk commented Oct 24, 2023 •
edited by github-actions bot

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6632349435
❌ Publish Java CDK version=0.1.12 failed!

@akashkulk akashkulk requested a review from a team as a code owner October 24, 2023 21:22
@akashkulk
Copy link
Contributor Author

akashkulk commented Oct 24, 2023 •
edited by github-actions bot

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/6632776874
✅ Successfully published Java CDK version=0.1.12!

@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 24, 2023 21:36
@airbyte-oss-build-runner
Copy link
Collaborator

source-mysql test report (commit 590d5e5d41) - ❌

⏲️ Total pipeline duration: 03mn30s

Step Result
Build connector tar ❌
Validate metadata for source-mysql ✅
Connector version semver check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@airbyte-oss-build-runner
Copy link
Collaborator

source-postgres test report (commit 590d5e5d41) - ❌

⏲️ Total pipeline duration: 01mn26s

Step Result
Build connector tar ❌
Validate metadata for source-postgres ✅
Connector version semver check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

@aaronsteers aaronsteers mentioned this pull request Oct 24, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii removed area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Oct 24, 2023
@akashkulk akashkulk enabled auto-merge (squash) October 24, 2023 22:03
@akashkulk akashkulk enabled auto-merge (squash) October 24, 2023 22:14
@akashkulk akashkulk merged commit a390830 into master Oct 24, 2023
22 checks passed
@akashkulk akashkulk deleted the akash/dbz-silent-failure branch October 24, 2023 22:20
@akashkulk akashkulk mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodireich rodireich rodireich approved these changes

@subodh1810 subodh1810 Awaiting requested review from subodh1810

@prateekmukhedkar prateekmukhedkar Awaiting requested review from prateekmukhedkar

Assignees
No one assigned
Labels
CDK Connector Development Kit connectors/source/mysql connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akashkulk @airbyte-oss-build-runner @rodireich @octavia-squidington-iii