-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java CDK: hoist top-level gradle projects into CDK #31960
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
According to
I will run the connectors test manually on each of there:
all ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a dangerous file. won't even display the diff in github web UI... And even if it did, it would be unreadable since it's just a single line... Would you be open to remerging to main, if I reformat this file first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless this is automatically generated by some test, in which case we should modify that to add proper formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, this needs to be added to the .gitignore. Or rather replace the current entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is even more dangerous than you think, in this project's gradle.build
you'll find a downloadConnectorRegistry
task that's a dependency of processResources
and this task HTTP GETs this json file from one of our services. Yeah...
Still, this file shouldn't have been touched in this PR, only moved. I'll look into this. Thanks for noticing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I responded to your top-level comment without refreshing the page. You're right, this needs a gitignore update. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to be paranoid about very large changes. In a previous job, someone fixed spotbugs in a 3k+ files at once and at the same time buried a change to the javac command line. So thank you for not doing that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. I try to have each change either change form or function but not both. This is a "form" change for sure.
looks like we're setting useLocalCdk to true in a lot of gradle files. Do we understand the ins and outs of doing that?
|
The This workflow is veeeery much a work in progress and not something we intend to settle on. The CDK is fairly new as a concept, we haven't fleshed everything out. |
Thanks for the review! I'll wait for the github actions to complete and then I'll publish the CDK with version 0.2.0, and so forth, before merging. |
/publish-java-cdk dry-run=true
|
/publish-java-cdk
|
/approve-and-merge reason="bump CDK deps for all connectors" |
Approve-and-merge failed with |
I missed this PR earlier - we intentionally excluded the typing-deduping modules from the initial CDK release because they're still under very active development and going through a lot of breaking changes. Is there a technical barrier to unhoisting those two specific projects? |
I didn't realize that. There's no obstacle to unhoisting these projects and they're pretty far down the dependency chain anyway. Alternatively, we can simply ignore the published jars for the time being and redefine the dependencies to typing-deduping as being from source, like previously. At that point, the only difference will be the gradle project name. I'll open a PR and add you as a reviewer. |
Fulfilling this TODO item that's been there since the inception of the Java CDK should help speed up building java connectors.
Not all projects have been hoisted, only those which connectors depend on, directly or transitively.
Fixes #31400