-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-lib: Connector documentation #33063
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TODO: Reimplement json schema rendering |
Honestly looks way better designed than the out of the box solution! Looks great. |
Thanks @nataliekwong !
We can actually control this, added some logic to show the required ones first (this is the advantage of using a custom-built solution here)
Not sure I follow, could you elaborate on that point? |
@timroes I adopted @nora-airbyte s design and made it more table-y: IMHO it looks pretty cool. Could you give it a review? |
|
||
## Usage with airbyte-lib | ||
|
||
For document file type streams, make sure the `tesseract` and `pdftotext` libraries are installed. On MacOS, you can install them with `brew install poppler tesseract`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we putting MacOS
specifically here as an example to install those, but no other system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just an example, I will remove it from this PR before merging (only the pure implementation of the components will go on, rolling it out to connectors on a separate PR)
|
||
for record in result.cache.streams["my_stream:name"]: | ||
print(record)`} </CodeBlock> | ||
<p>You can find more information in the airbyte_lib quickstart guide.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this quickstart guide already exist, so we could link to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't yet - I will work on this on a separate PR. As mentioned, this component will not be rendered yet, in this PR I just want to get the first version of the components ready.
Generally I feel this looks pretty good. The only thing irking me a bit is how we display arrays. We somehow nest a Specifically for arrays of primitive datatypes like string[] this looks imho more confusing then helpful: Is there any chance for simple arrays to render it as |
Thanks @timroes ! Your suggestions for arrays make a lot of sense to me - I will implement that. |
@timroes Done - it's now showing the properties of the array items directly. I did a similar thing for constant values - they are rendered as the "type" now: |
If you are OK with the basic component I will remove the actual usages so we can get the pre-requisite in. |
Add capabilities to effectively document airbyte-lib-enabled connectors to our doc system:
The new components are picked up by a new remark plugin that's injecting the spec of the connector as a prop to the component so it can be used to render out a generated sample config / the spec schema.
This adds the following dependencies:
json-schema-faker
to generate an example config object only based on the schema@headlessui/react
for the collapsible implementationsanitize-html
to safely render HTML from the schema in the docsSee the following connector doc pages for examples: