airbyte-ci: Add upgrade cdk command #33313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
December 1, 2023 12:08
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
added 2 commits
December 12, 2023 11:45
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/upgrade_cdk/commands.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/upgrade_cdk/commands.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/upgrade_cdk/pipeline.py
Outdated
Show resolved
Hide resolved
| new_version: str, | ||
| ): | ||
| super().__init__(context) | ||
| self.repo_dir = repo_dir |
There was a problem hiding this comment.
repo_dir is already an attribute of context
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/upgrade_cdk/pipeline.py
Outdated
Show resolved
Hide resolved
| set_cdk_version_result = await set_cdk_version.run() | ||
| steps_results.append(set_cdk_version_result) | ||
| final_repo_dir = set_cdk_version_result.output_artifact | ||
| await og_repo_dir.diff(final_repo_dir).export(str(git.get_git_repo_path())) |
There was a problem hiding this comment.
Shall we move the export logic back to the SetCDKVersion so that a failed export fails the step (and the report)?
Comment on lines
90
to
91
| final_repo_dir = set_cdk_version_result.output_artifact | ||
| await og_repo_dir.diff(final_repo_dir).export(str(git.get_git_repo_path())) |
There was a problem hiding this comment.
I think we should export the connector directory and not the full repo directory. This will improve performances.
Comment on lines
22
to
23
| def connector_with_poetry(): | ||
| return Connector("destination-duckdb") |
There was a problem hiding this comment.
It'd be more stable to not rely on a single connector. I suggest to iterate on the all_connectors fixture and return a connector which has a pyproject.toml file and skip otherwise.
Suggested change
| def connector_with_poetry(): | |
| return Connector("destination-duckdb") | |
| def connector_with_poetry(all_connectors): | |
| for connector in all_connectors: | |
| if (connector.code_directory / "pyproject.toml").exists(): | |
| return connector | |
| pytest.skip("No connector using poetry found") |
|
Thanks for your comments @alafanechere - I adjusted the code and wrote some tests, could you take another look? |
alafanechere
approved these changes
Dec 15, 2023
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/upgrade_cdk/pipeline.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/upgrade_cdk/pipeline.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/upgrade_cdk/pipeline.py
Outdated
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/upgrade_cdk/pipeline.py
Show resolved
Hide resolved
airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/upgrade_cdk/commands.py
Outdated
Show resolved
Hide resolved
alafanechere
approved these changes
Dec 18, 2023
| async def _run(self) -> StepResult: | ||
| context: ConnectorContext = self.context | ||
| og_connector_dir = await context.get_connector_dir() | ||
| if not "setup.py" in await og_connector_dir.entries(): |
There was a problem hiding this comment.
Can we return self.skip(reason="Connector is not a Python connector") when the connector is a Java connector?
timroes
pushed a commit
that referenced
this pull request
Dec 19, 2023
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command to airbyte-ci that allows updating the CDK version in connectors. It's mostly meant to be called in an automated fashion from Github Action workflows to auto-upgrade connectors after an upgrade.
Prod version of #32721