Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-mssql: shorten capture job polling interval in tests #33510

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Dec 14, 2023

This PR should reduce flakiness in tests.

SQL Server is different than Postgres and MySql in that its CDC functionality consists of more than just parsing the WAL, instead it involves background jobs writing to _CT tables whose contents are eventually consistent. The background job of type "capture" does its thing every 5 seconds by default. If we have two consecutive reads within less than 5 seconds we might end up with the same target LSN despite having committed transactions between the two reads!

This PR reduces the polling interval to every 1 second in tests and waits the same amount of time before querying the target LSN. The latter depends on the contents of the _CT tables and we want to give them a chance to be updated.

@postamar postamar requested a review from a team as a code owner December 14, 2023 20:52
Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 3:40pm

Copy link
Contributor Author

Copy link
Contributor

github-actions bot commented Dec 14, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@postamar
Copy link
Contributor Author

postamar commented Jan 8, 2024

This makes the tests flaky for some as-of-yet unknown reason.

@postamar
Copy link
Contributor Author

postamar commented Jan 8, 2024

Fixed. As it turns out, adding the missing is_test field in the config does have an impact!

@postamar postamar merged commit c284588 into master Jan 8, 2024
26 of 27 checks passed
@postamar postamar deleted the postamar_gt_12-14-shorten_capture_job_polling_interval_in_tests branch January 8, 2024 21:05
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/mssql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants