Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨🚨 Source JIRA: Save state for Boards Issues per board #33715

Merged
merged 10 commits into from
Jan 10, 2024
Merged

🚨🚨 Source JIRA: Save state for Boards Issues per board #33715

merged 10 commits into from
Jan 10, 2024

Conversation

artem1205
Copy link
Collaborator

What

Resolving https://github.com/airbytehq/oncall/issues/3757

How

Save State for every board in stream Boards Issues

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

state has changes for stream Boards Issues

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel Vercel
Copy link

vercel bot commented Dec 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2024 11:05pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023 •
edited
Loading

Warning

🚨 Connector code freeze is in effect until 2024-01-02. This PR is changing connector code. Please contact the current OC engineers if you want to merge this change to master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023 •
edited by artem1205
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 marked this pull request as ready for review December 22, 2023 17:52
@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 3, 2024 21:53
lazebnyi
lazebnyi approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

need small changes

airbyte-integrations/connectors/source-jira/source_jira/streams.py Outdated
Comment on lines 331 to 332
board_id = str(stream_slice["board_id"])
if stream_state:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need assign board_id before if statement. It's used only stream_state not false.

airbyte-integrations/connectors/source-jira/source_jira/streams.py Outdated
@@ -288,17 +296,45 @@ def should_retry(self, response: requests.Response) -> bool:
# for all other HTTP errors the default handling is applied
return super().should_retry(response)

def stream_slices(self, **kwargs) -> Iterable[Optional[Mapping[str, Any]]]:
self._starting_point_cache.clear()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comment why we need do this

@artem1205 artem1205 merged commit 1ac5029 into master Jan 10, 2024
24 checks passed
@artem1205 artem1205 deleted the codefreeze-23-12/source-jira/1.0.0 branch January 10, 2024 11:20
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@artem1205 @jatinyadav-cc
🚨🚨 Source JIRA: Save state for Boards Issues per board (airbytehq#33715)
87829f3
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@artem1205 @jatinyadav-cc
🚨🚨 Source JIRA: Save state for Boards Issues per board (airbytehq#33715)
279a5eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

@katmarkham katmarkham katmarkham approved these changes

@darynaishchenko darynaishchenko Awaiting requested review from darynaishchenko

@roman-yermilov-gl roman-yermilov-gl Awaiting requested review from roman-yermilov-gl

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artem1205 @katmarkham @lazebnyi @octavia-squidington-iii