🎉 Source Facebook Marketing: Allow configuring insights lookback window - #3396
Conversation
| "type": "boolean", | ||
| "description": "Include data from deleted campaigns, ads, and adsets.", | ||
| "default": "false" | ||
| }, |
There was a problem hiding this comment.
this is the first step, but this needs to be passed into the connector so it would actually use this value.
Also, could you add a test using a mocked HTTP request to verify this works?
Sherif A. Nada (sherifnada)
changed the title
…-configuring-Facebook-Marketing-insights-buffer-days To catch up master changes
Sherif A. Nada (sherifnada)
left a comment
Sherif A. Nada (sherifnada)
left a comment
There was a problem hiding this comment.
LGTM! Feel free to bump version and publish when ready.
Also, there seems to be unrelated changes. Do you know what those are from?
…insights-buffer-days
What changes? |
…Marketing-insights-buffer-days' into 2920-Allow-configuring-Facebook-Marketing-insights-buffer-days
|
/publish connector=connectors/source-facebook-marketing
|
|
/test connector=source-facebook-marketing
|
3 participants
What
Adding new filed to customize in facebook marketing api #2920
How
Updated spec.json file with new fileld settings and changed init method in Client and AdsInsightApi
Pre-merge Checklist
Recommended reading order