Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: fix assertion error on report existence #33979

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 5, 2024

The report attribute is sometime accessed on the pipeline context before it's set, so it can be None.

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 9:32pm

Copy link
Contributor Author

alafanechere commented Jan 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/01-05-airbyte-ci_fix_assertion_error_on_report_existence branch from 05f5b33 to b7846ca Compare January 5, 2024 17:57
@alafanechere alafanechere marked this pull request as ready for review January 5, 2024 17:58
@alafanechere alafanechere requested review from a team and erohmensing January 5, 2024 17:58
@alafanechere alafanechere force-pushed the augustin/01-05-airbyte-ci_fix_assertion_error_on_report_existence branch from b7846ca to f320d7e Compare January 8, 2024 20:58
@alafanechere alafanechere force-pushed the augustin/01-05-airbyte-ci_fix_assertion_error_on_report_existence branch from f320d7e to c126821 Compare January 8, 2024 21:30
@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="minor airbyte-ci fix to unblock upcoming development"

@octavia-approvington
Copy link
Contributor

Myomoto says it looks good
thats a niiice

@octavia-approvington octavia-approvington merged commit 99488dd into master Jan 9, 2024
21 checks passed
@octavia-approvington octavia-approvington deleted the augustin/01-05-airbyte-ci_fix_assertion_error_on_report_existence branch January 9, 2024 15:30
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants