Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: log more context info in CI #33994

Merged

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 8, 2024

It can be convenient for debugging to log the airbyte-ci and dagger version in use for a CI run.
This will get logged in CI only, along with the other git information.

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2024 8:20am

Copy link
Contributor Author

alafanechere commented Jan 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/01-08-airbyte-ci_log_more_context_info_in_CI branch from 3273d59 to 408ff64 Compare January 8, 2024 08:20
@alafanechere alafanechere marked this pull request as ready for review January 8, 2024 08:32
@alafanechere alafanechere requested a review from a team January 8, 2024 08:32
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How I always feel about debugging info:

image

@@ -81,7 +82,9 @@ def set_working_directory_to_root() -> None:
os.chdir(working_dir)


def log_git_info(ctx: click.Context) -> None:
def log_context_info(ctx: click.Context) -> None:
main_logger.info(f"Running airbyte-ci version {__installed_version__}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love if we could add (local install) or (binary install) to this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit harder to get in this context, but we can currently quite well assess from the workflow logs if pipx is used to install airbyte-ci or if the bin is downloaded.

@alafanechere alafanechere merged commit 4955933 into master Jan 8, 2024
26 checks passed
@alafanechere alafanechere deleted the augustin/01-08-airbyte-ci_log_more_context_info_in_CI branch January 8, 2024 20:00
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants