-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: log more context info in CI #33994
airbyte-ci: log more context info in CI #33994
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on Graphite |
3273d59
to
408ff64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -81,7 +82,9 @@ def set_working_directory_to_root() -> None: | |||
os.chdir(working_dir) | |||
|
|||
|
|||
def log_git_info(ctx: click.Context) -> None: | |||
def log_context_info(ctx: click.Context) -> None: | |||
main_logger.info(f"Running airbyte-ci version {__installed_version__}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love if we could add (local install)
or (binary install)
to this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a bit harder to get in this context, but we can currently quite well assess from the workflow logs if pipx is used to install airbyte-ci or if the bin is downloaded.
It can be convenient for debugging to log the airbyte-ci and dagger version in use for a CI run.
This will get logged in CI only, along with the other git information.