Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: connector test steps can take extra parameters from CLI #34050

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 9, 2024

What

Closes #24061

This PR is used to merge all the PR from the stack to create a new minor version of airbyte-ci in which users can pass extra parameters to connector test steps from the CLI

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2024 10:41am

@alafanechere alafanechere force-pushed the augustin/01-09-airbyte-ci_connector_test_steps_can_take_extra_parameters_from_CLI branch from 18a3db7 to 4f76f3e Compare January 9, 2024 16:23
@alafanechere alafanechere marked this pull request as ready for review January 10, 2024 16:28
@alafanechere alafanechere requested a review from a team January 10, 2024 16:28
@alafanechere alafanechere force-pushed the augustin/01-09-airbyte-ci_connector_test_steps_can_take_extra_parameters_from_CLI branch 2 times, most recently from 90b1edc to c4b4ecd Compare January 12, 2024 09:35
@alafanechere alafanechere force-pushed the augustin/01-09-airbyte-ci_connector_test_steps_can_take_extra_parameters_from_CLI branch from c4b4ecd to aed7565 Compare January 15, 2024 07:55
@alafanechere alafanechere force-pushed the augustin/01-09-airbyte-ci_connector_test_steps_can_take_extra_parameters_from_CLI branch from c1b1ff0 to 50826cd Compare January 15, 2024 10:39
@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="formatting airbyte-ci code is broken for known reasons. I checked that formatting passes locally"

@octavia-approvington
Copy link
Contributor

Lets merge it
sheep thumbs up

@octavia-approvington octavia-approvington merged commit 8d27b6b into master Jan 15, 2024
20 of 21 checks passed
@octavia-approvington octavia-approvington deleted the augustin/01-09-airbyte-ci_connector_test_steps_can_take_extra_parameters_from_CLI branch January 15, 2024 10:55
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the -k ability to the airbyte-ci test command
3 participants