Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra explanation about dbs in namespaces docs #3420

Merged
merged 1 commit into from
May 18, 2021

Conversation

cgardens
Copy link
Contributor

What

  • Addressing a common question that I have heard.

@auto-assign auto-assign bot requested review from davinchia and jrhizor May 14, 2021 17:54
@cgardens cgardens removed the request for review from jrhizor May 14, 2021 17:54
@@ -10,11 +10,13 @@ An example of a namespace is the RDMS's `schema` concept. Some common use cases

The Airbyte Protocol supports namespaces and allows Sources to define namespaces, and Destinations to write to various namespaces.

The most common use of namespaces is in the context of database sources and destinations. For databases, generally, a namespace is synonymous with a schema. In the Postgres source, for example, the table `public.users` would be represented in Airbyte as `{ "namespace": "public", "name" "users" }`. If replicating this into a destination that supports namespacing, by default, records from this table would be replicated into `public.users` in the destination.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more I see questions about it the least good I feel about how we've forced a decision, because we don't know what users want here and right now we make an assumption.
if I enumerate the two cases:

  1. I want my namepace.table to show as a namespace and table in my destination (generally makes sense for databases)
  2. I want my namepace.table to show as a table in my destination in a namespace that I decided (generally makes sense for datawarehouses)

Right now we just always go for the first solution which doesn't seem right. Do you share the same feeling?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap. Agree with you on the two options. I'm less sure on the database/warehouse split. From the users I've spoken to, wanting to replicate into a custom namespace/schema seems more arbitrary and related to legacy reasons than anything else e.g. existing pipeline already expects this.

When @cgardens and I discussed, it was very much to get something out that solves the problem of clashing names, get feedback and adjust. Maybe we can decide we've heard enough and can prioritise making destination namespace configurable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for documentation!

@cgardens cgardens merged commit 40e45d7 into master May 18, 2021
@cgardens cgardens deleted the cgardens/namespaces_docs_dbs branch May 18, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants