Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update Getting Started #34237

Merged
merged 14 commits into from
Jan 18, 2024
Merged

[Docs] Update Getting Started #34237

merged 14 commits into from
Jan 18, 2024

Conversation

nataliekwong
Copy link
Contributor

@nataliekwong nataliekwong commented Jan 13, 2024

What

Updates the Getting Started example

How

  • Changes the source to use Sample Data (Faker)
  • Adds a Cloud-specific destination of Google Sheets (Local JSON is not available on Cloud)

plus miscellaneous spelling edits and additional product screenshots

Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 7:07pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 13, 2024
@@ -2,6 +2,10 @@
products: all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can this one page be for oss and cloud only (exclude self-managed enterprise, which has it's own getting started page)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since this is the getting started page for "using airbyte" while the Enterprise docs focus more on setting it up, I feel this page still applies to |Enterprise users as well. I feel it's def worth though putting a paragraph in here besides Cloud and OSS to link to the Enterprise setup page! cc @nataliekwong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. What do you think of the changes?

Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some typo corrections. Overall looks good to me.

@nataliekwong nataliekwong merged commit 14c6199 into master Jan 18, 2024
22 checks passed
@nataliekwong nataliekwong deleted the natalie/getting-started branch January 18, 2024 19:15
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: Tim Roes <tim@airbyte.io>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Co-authored-by: Tim Roes <tim@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants