Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add run method in run.py #34241

Merged
merged 1 commit into from
Jan 15, 2024
Merged

add run method in run.py #34241

merged 1 commit into from
Jan 15, 2024

Conversation

mostafa6765
Copy link
Contributor

@mostafa6765 mostafa6765 commented Jan 14, 2024

what

run.py

  • add run() inside run.py
    -> airbyte-integrations/connector-templates/source-python/main.py.hbs
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#

from source_{{snakeCase name}}.run import run

if __name__ == "__main__":
    run()

NB: but source_{{snakeCase name}}.run has no run method

How

  • python3 main.py spec -> Now there have import issue. so this PR will solve this issue

@mostafa6765 mostafa6765 requested a review from a team as a code owner January 14, 2024 17:25
Copy link

vercel bot commented Jan 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2024 5:25pm

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @mostafa6765

@flash1293
Copy link
Contributor

@mostafa6765 It's just a formality, but could you sign the CLA (seethe failing GH check)? Then I can merge it in

@mostafa6765
Copy link
Contributor Author

@mostafa6765 It's just a formality, but could you sign the CLA (seethe failing GH check)? Then I can merge it in

@flash1293 CLA sign is done.

@flash1293 flash1293 merged commit 29852cf into airbytehq:master Jan 15, 2024
29 of 33 checks passed
@flash1293
Copy link
Contributor

@mostafa6765 Thanks, merged and done!

jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants