CAT: fixed TestSpec.test_oauth_is_default_method to skip connector spec without predicate key #34559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
darynaishchenko
requested review from
maxi297,
bazarnov,
artem1205 and
brianjlai
brianjlai
approved these changes
Jan 27, 2024
bazarnov
approved these changes
Jan 27, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
…ec without predicate key (airbytehq#34559)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…ec without predicate key (airbytehq#34559)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…ec without predicate key (airbytehq#34559)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
TestSpec.test_oauth_is_default_method failed with TypeError for connectors that do not have predicate_key in advanced auth object.
How
Added skip for this test in case no predicate key in advanced auth object.
Predicate Key docs: JSON path to a field in the connectorSpecification that should exist for the advanced auth to be applicable.
Manually tested on