Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a resume token with a pipeline consisting of selected streams #34594

Conversation

rodireich
Copy link
Contributor

@rodireich rodireich commented Jan 29, 2024

Scope initial resume token creation to just the database & streams chosen by the user. Also set debezium properties to scope the Change stream target to database (instead of deployment)

This logic is similar to how Debezium creates the initial resume token.

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 5:33pm

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@rodireich
Copy link
Contributor Author

Equivalent to mongosh:

let cur = db.watch([
  { $match: { "ns.coll": {$in: ["amazonorders", "bankTransactions", "finaloopProducts"]} }}
], { })

…cremental-read-with-resume-token-was-not-found
…cremental-read-with-resume-token-was-not-found
@akashkulk akashkulk marked this pull request as ready for review January 30, 2024 23:04
@akashkulk akashkulk changed the title build a resume token with a pipeline consisting of selected streams Build a resume token with a pipeline consisting of selected streams Jan 30, 2024
…cremental-read-with-resume-token-was-not-found
@akashkulk akashkulk merged commit eb5b23d into master Jan 31, 2024
25 checks passed
@akashkulk akashkulk deleted the 33790-source-mongodb-v2-failing-to-make-incremental-read-with-resume-token-was-not-found branch January 31, 2024 17:48
jbfbell pushed a commit that referenced this pull request Feb 1, 2024
…34594)

Co-authored-by: Akash Kulkarni <akash@airbyte.io>
Co-authored-by: Akash Kulkarni <113392464+akashkulk@users.noreply.github.com>
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
…34594)

Co-authored-by: Akash Kulkarni <akash@airbyte.io>
Co-authored-by: Akash Kulkarni <113392464+akashkulk@users.noreply.github.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
…irbytehq#34594)

Co-authored-by: Akash Kulkarni <akash@airbyte.io>
Co-authored-by: Akash Kulkarni <113392464+akashkulk@users.noreply.github.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…irbytehq#34594)

Co-authored-by: Akash Kulkarni <akash@airbyte.io>
Co-authored-by: Akash Kulkarni <113392464+akashkulk@users.noreply.github.com>
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
…irbytehq#34594)

Co-authored-by: Akash Kulkarni <akash@airbyte.io>
Co-authored-by: Akash Kulkarni <113392464+akashkulk@users.noreply.github.com>
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
…34594)

Co-authored-by: Akash Kulkarni <akash@airbyte.io>
Co-authored-by: Akash Kulkarni <113392464+akashkulk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mongodb-v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

source-mongodb-v2 failing to make incremental read with "resume token was not found"
3 participants