Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source S3: pin CDK and moto #34665

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Source S3: pin CDK and moto #34665

merged 2 commits into from
Feb 1, 2024

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Jan 30, 2024 •
edited
Loading

Attempt to fix CATs that have been failing on master since 28 Jan.

Issue for unpinning moto created here.

@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2024 5:25pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited by clnoll
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 30, 2024 16:25
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jan 30, 2024
@clnoll clnoll requested a review from maxi297 January 30, 2024 16:25
maxi297
maxi297 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question

airbyte-integrations/connectors/source-s3/setup.py Show resolved Hide resolved
maxi297
maxi297 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like CATs are still failing with botocore.exceptions.NoCredentialsError: Unable to locate credentials

maxi297
maxi297 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment to explain why we pin moto to make sure the knowledge don't get lost. Apart from that, I'm all in for this PR

@clnoll clnoll force-pushed the source-s3-pin-moto branch 2 times, most recently from 8420d48 to 49062b8 Compare February 1, 2024 17:09
@clnoll clnoll merged commit d05f473 into master Feb 1, 2024
24 of 25 checks passed
@clnoll clnoll deleted the source-s3-pin-moto branch February 1, 2024 17:52
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
@clnoll @xiaohansong
Source S3: pin CDK and moto (#34665)
07ebba0
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@clnoll @jatinyadav-cc
Source S3: pin CDK and moto (airbytehq#34665)
879de29
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@clnoll @jatinyadav-cc
Source S3: pin CDK and moto (airbytehq#34665)
462ef43
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@clnoll @jatinyadav-cc
Source S3: pin CDK and moto (airbytehq#34665)
b4774f5
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@clnoll @xiaohansong
Source S3: pin CDK and moto (#34665)
252f3bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxi297 maxi297 maxi297 approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clnoll @maxi297 @octavia-squidington-iii