-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Recharge: Added the UI toggle Use 'Orders' Deprecated API
to switch between deprecated
and modern
api versions for Orders
stream
#34707
Merged
bazarnov
merged 10 commits into
master
from
baz/source-recharge/fix-orders-missing-records
Feb 1, 2024
Merged
🐛 Source Recharge: Added the UI toggle Use 'Orders' Deprecated API
to switch between deprecated
and modern
api versions for Orders
stream
#34707
bazarnov
merged 10 commits into
master
from
baz/source-recharge/fix-orders-missing-records
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/fix-orders-missing-records
…/fix-orders-missing-records
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
Connector related issues
connectors/source/recharge
labels
Jan 31, 2024
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Jan 31, 2024
…/fix-orders-missing-records
darynaishchenko
approved these changes
Feb 1, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
…to switch between `deprecated` and `modern` api versions for `Orders` stream (#34707)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
…to switch between `deprecated` and `modern` api versions for `Orders` stream (airbytehq#34707)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…to switch between `deprecated` and `modern` api versions for `Orders` stream (airbytehq#34707)
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
…to switch between `deprecated` and `modern` api versions for `Orders` stream (airbytehq#34707)
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
…to switch between `deprecated` and `modern` api versions for `Orders` stream (#34707)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/recharge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolving: https://github.com/airbytehq/oncall/issues/3860
How
Orders
stream class into 2 separate classes:OrdersModernApi
andOrdersDeprecatedApi
to theapi.py
to be able to switch between the two via UI toggle:Use 'Orders' Deprecated API
Orders
stream schema to cover the new properties introduced in the2021-11
API version (ModernApi)select_orders_stream
method stream Selector tosource.py
to define which API to use, based on the user's input configuration.expected_records
since the CAT test is failing🚨 User Impact 🚨
No impact is expected, because this is not a breaking change, the default value for the new UI toggle is
True
, meaning for all the existing connections nothing will change, they will remain onDeprecatedAPI
version.To change this, change the toggle value in the UI to False and continue with the syncs.