Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-postgres: adopt cleaned-up cdk #34751

Merged
merged 2 commits into from
Feb 9, 2024
Merged

source-postgres: adopt cleaned-up cdk #34751

merged 2 commits into from
Feb 9, 2024

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Feb 1, 2024 •
edited
Loading

Based on #34745.

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 2:27am

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Feb 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited by postamar
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@postamar postamar force-pushed the postamar/cdk-cleanup-base-pr branch 4 times, most recently from 1783750 to 44f72bb Compare February 1, 2024 21:23
@postamar postamar force-pushed the postamar/cdk-cleanup-source-postgres branch from ea80dc7 to e3a49e4 Compare February 1, 2024 21:27
@postamar postamar force-pushed the postamar/cdk-cleanup-base-pr branch 3 times, most recently from 9efadca to 894c72a Compare February 8, 2024 22:25
@postamar postamar force-pushed the postamar/cdk-cleanup-source-postgres branch from e3a49e4 to 7a3ace6 Compare February 9, 2024 00:12
Base automatically changed from postamar/cdk-cleanup-base-pr to master February 9, 2024 01:46
@postamar postamar force-pushed the postamar/cdk-cleanup-source-postgres branch from 7a3ace6 to 691d2c5 Compare February 9, 2024 01:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024 •
edited
Loading

Coverage report for source-postgres

File Coverage [88.33%] 🍏
PostgresSource.java 88.33% 🍏
Total Project Coverage 69.26% 🍏

@postamar postamar force-pushed the postamar/cdk-cleanup-source-postgres branch from 691d2c5 to f0fc041 Compare February 9, 2024 02:10
@postamar postamar force-pushed the postamar/cdk-cleanup-source-postgres branch from f0fc041 to a400687 Compare February 9, 2024 02:20
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 9, 2024
@postamar postamar marked this pull request as ready for review February 9, 2024 02:32
@postamar postamar requested a review from a team as a code owner February 9, 2024 02:32
@postamar postamar enabled auto-merge (squash) February 9, 2024 02:40
@postamar postamar merged commit 7ff4848 into master Feb 9, 2024
33 checks passed
@postamar postamar deleted the postamar/cdk-cleanup-source-postgres branch February 9, 2024 19:41
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
@postamar @xiaohansong
source-postgres: adopt cleaned-up cdk (#34751)
28ae2b1
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@postamar @jatinyadav-cc
source-postgres: adopt cleaned-up cdk (airbytehq#34751)
8a824fb
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@postamar @jatinyadav-cc
source-postgres: adopt cleaned-up cdk (airbytehq#34751)
dcff0ae
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@postamar @jatinyadav-cc
source-postgres: adopt cleaned-up cdk (airbytehq#34751)
7db20ea
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@postamar @xiaohansong
source-postgres: adopt cleaned-up cdk (#34751)
a086a40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashkulk akashkulk akashkulk approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@postamar @akashkulk @octavia-squidington-iii