Connector templates: Publish by default #34766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
The CI failure seems to be a flaky thing in the concurrent CDK |
girarda
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
I'm ok with this change.
@alafanechere or @pedroslopez are there additional restrictions required before releasing connectors to Cloud? If yes, we should leave the cloud flag to false
alafanechere
reviewed
Feb 5, 2024
There was a problem hiding this comment.
I'm slightly concerned about enabling cloud deployment by default.
The idea in disabling it by default was to not clutter Airbyte Cloud with alpha / deceptive connectors.
I'd love @katmarkham take on it.
IMO it's safer to enable OSS - disable cloud by default.
added 2 commits
February 6, 2024 10:28
|
Yeah, I can see that. Disabled cloud again |
katmarkham
approved these changes
Feb 6, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our connector templates have all "publish" flags set to off.
This already caused issue in the past with connectors not published after the initial merge to master: https://github.com/airbytehq/airbyte/pull/31160/files#diff-110e24d902ed804a2da7b4c542e3bd84131e7688831f92c46b6cd81ed3aa7e0fR6
As connectors are written to be used, let's be more bold about this and set all publish flags (cloud, remote and python) to on by default and disabled them during the review process if necessary.
I can be convinced of disabling cloud by default as there is a slight risk to this, but for OSS and python I think the downside of forgetting to publish connectors is bigger than the downside of having to pull a connector in the off-case