Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove connector health page and display all connectors on the root connectors page #3478

Merged
merged 3 commits into from
May 29, 2021

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented May 19, 2021

What

The connector health page previously displayed build statuses for connectors. This is tricky to message correctly, as it just showed the build status of connectors, which does not necessarily correlate with whether the connector will work when deployed by a user. A vast majority of the time when a connector build is failing, it's because of a problem with the sandbox account or the API token etc.. and not because there is an actual issue with the connector.

The correct structure here imo is:

  1. Display all connectors without build status on the root connectors page in the docs
  2. Alert the Airbyte dev team when one of the . I've created a separate issue to track this here: Setup alerts for failed connector builds #3477

How

This PR performs step 1 above.

┆Issue is synchronized with this Asana task by Unito

Copy link
Contributor

@michel-tricot michel-tricot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you work with @johnlafleur to also update airbyte.io

@johnlafleur
Copy link
Contributor

johnlafleur commented May 19, 2021

Some comments:

  • After some thoughts, I actually wouldn't make the difference between what was provided by the community vs Airbyte. The question is was it certified. So I would change the list to "Airbyte Certified" and "Not certified yet", and it's an opportunity for what certification means
  • This means that the structure would be:
    ** Sources
    *** Airbyte Certified Sources
    *** Not Certified yet
    ** Destinations

I don't think we care whether it comes from us or the community, it's whether it's high quality and certified or not. And maybe we can even add documentation on how they can help us certify the not-certified-yet ones.

@sherifnada
Copy link
Contributor Author

@johnlafleur maybe we can break down airbyte connectors further into alpha/beta/certified etc.. but the main message is whether we provide support for something or not, in which case the distinction between community vs airbyte provided is important. WDYT?

@johnlafleur
Copy link
Contributor

johnlafleur commented May 19, 2021

Are you sure we won't provide any support for community-provided connectors? Oracle DB was provided by the community. What if other important connected are provided by the community?

So alpha/beta/certified in my mind makes more sense.

@cgardens
Copy link
Contributor

Will we still be able to access this dashboard internally somehow?

@jrhizor
Copy link
Contributor

jrhizor commented May 19, 2021

Agreed with John that we should have a commitment to maintenance not the source of the connector since we do want to adopt Oracle as a core connector but maybe not others in the future.

I think until #3477 it would be useful to have a view for the build status without it being a page intended for user consumption. We can include disclaimers and not refer to it as connector health. It's very difficult to browse build history without.

@sherifnada
Copy link
Contributor Author

sherifnada commented May 19, 2021

@jrhizor @johnlafleur would the point be addressed if we call it "Airbyte maintained" instead of "provided" ? same for community

@johnlafleur
Copy link
Contributor

It would imply that we don't maintain the others, which we may not. The thing is we will maintain the ones that are the most important and used. And some of them might be now in the not-maintained list. I feel this is not the perception we want to give. I think certified / alpha / beta is they way to go, personally.

@sherifnada sherifnada linked an issue May 26, 2021 that may be closed by this pull request
@sherifnada
Copy link
Contributor Author

Fixed concerns. Separated into alpha/beta/certified. Also added an MD page to find build statuses in the integrations/ directory.

@johnlafleur
Copy link
Contributor

Looks good!

@sherifnada sherifnada merged commit 248c285 into master May 29, 2021
@sherifnada sherifnada deleted the sherif/refactor-connector-catalog-docs branch May 29, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework connector health page
6 participants