-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: embed junit xml reports into user-facing html report #34923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
postamar
force-pushed
the
postamar/airbyte-ci-uploads-gradle-reports
branch
from
February 7, 2024 18:10
6afb48e
to
f5468af
Compare
postamar
changed the title
airbyte-ci: upload gradle test reports to gcs
airbyte-ci: embed junit xml reports into user-facing html report
Feb 7, 2024
stephane-airbyte
approved these changes
Feb 7, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34039
Tested this locally and with https://github.com/airbytehq/airbyte/actions/runs/7820041779
Expand "java unit tests" or "java integration tests" to see the new goodness:
We can worry about how to make it look at a later date. The original Junit XML format is tolerably readable as long as the system-out and system-err data are indented properly.
Note that gradle does render very pretty html reports but these are not single-page and copying them to a "subfolder" in our GCS bucket will mess with the relative refs in the html. I've given up that route completely in favour of embedding the test reports inside the overall html report. This also has the nice advantage of producing the same results locally vs. remotely.