Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Monday: add integration tests #35016

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Source Monday: add integration tests #35016

merged 3 commits into from
Feb 9, 2024

Conversation

roman-yermilov-gl
Copy link
Contributor

What

The issue: #34904

How

Cover streams defined as empty in acceptance-test-config.yaml with integraion tests

Recommended reading order

  1. unit_tests/integrations/*.py
  2. unit_tests/integrations/resource/http/response/*.json

@roman-yermilov-gl roman-yermilov-gl self-assigned this Feb 8, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 1:08pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited by roman-yermilov-gl
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-monday-integration-tests branch from 6339d55 to 909084c Compare February 8, 2024 13:37
@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review February 8, 2024 13:37
@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 8, 2024 13:38
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 8, 2024
lazebnyi
lazebnyi approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need small changes.

airbyte-integrations/connectors/source-monday/unit_tests/integrations/test_teams_stream.py
from .utils import get_log_messages_by_log_level, read_stream


class TestTeamsStreamFullRefresh(TestCase):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need change bypass reason in CAT config and mention that this stream has no tests data and tested with integration tests.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 9, 2024 13:09
@roman-yermilov-gl roman-yermilov-gl merged commit 0c3cccf into master Feb 9, 2024
23 of 24 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-monday-integration-tests branch February 9, 2024 13:20
xiaohansong pushed a commit that referenced this pull request Feb 13, 2024
@roman-yermilov-gl @xiaohansong
Source Monday: add integration tests (#35016)
b76c159
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
@roman-yermilov-gl @jatinyadav-cc
Source Monday: add integration tests (airbytehq#35016)
245ac20
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@roman-yermilov-gl @jatinyadav-cc
Source Monday: add integration tests (airbytehq#35016)
4983c24
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
@roman-yermilov-gl @jatinyadav-cc
Source Monday: add integration tests (airbytehq#35016)
e3b3abc
xiaohansong pushed a commit that referenced this pull request Feb 27, 2024
@roman-yermilov-gl @xiaohansong
Source Monday: add integration tests (#35016)
b26510b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

@bazarnov bazarnov bazarnov approved these changes

@artem1205 artem1205 Awaiting requested review from artem1205

Assignees

@roman-yermilov-gl roman-yermilov-gl

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/monday
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roman-yermilov-gl @bazarnov @lazebnyi @octavia-squidington-iii