-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sources with LEGACY STATE from registry #35038
Remove sources with LEGACY STATE from registry #35038
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
enabled: true | ||
enabled: false | ||
oss: | ||
enabled: true | ||
enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this PR also removes these connectors from the OSS repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢 I supported the merge of this contributed connectors two years ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its also safe to remove other singer based connector if any. They're all probably using the LEGACY STATE. And we can remove the generator for singer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are only 2 left!
/approve-and-merge reason="metadata-only changes for connectors whose tests don't pass" |
Slack Thread
From this Mb Query # of Connections active in the last 30 days:
source-talkdesk-explore - 0
source-kustomer-singer - 0
source-courier - 0
source-zuora - 1
source-dv-360 - 0
source-linnworks - 0
source-search-metrics - 0
source-appstore-singer - 0
source-recurly - 7
This PR also coincides with hiding these connectors from Cloud by adding the actors to the
connectors.hideActorDefinitionFromList
Feature Flag