Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sources with LEGACY STATE from registry #35038

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Feb 8, 2024

Slack Thread

From this Mb Query # of Connections active in the last 30 days:
source-talkdesk-explore - 0
source-kustomer-singer - 0
source-courier - 0
source-zuora - 1
source-dv-360 - 0
source-linnworks - 0
source-search-metrics - 0
source-appstore-singer - 0
source-recurly - 7

This PR also coincides with hiding these connectors from Cloud by adding the actors to the connectors.hideActorDefinitionFromList Feature Flag

Screenshot 2024-02-08 at 10 57 58 AM

Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 7:01pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Comment on lines -18 to +20
enabled: true
enabled: false
oss:
enabled: true
enabled: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this PR also removes these connectors from the OSS repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 I supported the merge of this contributed connectors two years ago

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its also safe to remove other singer based connector if any. They're all probably using the LEGACY STATE. And we can remove the generator for singer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are only 2 left!

@evantahler
Copy link
Contributor Author

/approve-and-merge reason="metadata-only changes for connectors whose tests don't pass"

@octavia-approvington
Copy link
Contributor

Check that box
TODO complete

@octavia-approvington octavia-approvington merged commit 4f95b81 into master Feb 8, 2024
33 of 46 checks passed
@octavia-approvington octavia-approvington deleted the evan/hide-legacy-state-connectors branch February 8, 2024 19:23
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants