add cors to version mismatch #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
approved these changes
May 20, 2021
jamakase
approved these changes
May 20, 2021
jamakase
reviewed
May 20, 2021
| private static final String ALLOW_ORIGIN = "Access-Control-Allow-Origin"; | ||
| private static final String ALLOW_HEADERS = "Access-Control-Allow-Headers"; | ||
| private static final String ALLOW_METHODS = "Access-Control-Allow-Methods"; | ||
| public static final String ALLOW_ORIGIN = "Access-Control-Allow-Origin"; |
There was a problem hiding this comment.
Small question, as we already use com.google.common.collect package that is part of guava, isn't it better to use com.google.common.net.HttpHeaders here and use
HttpHeaders.ACCESS_CONTROL_ALLOW_HEADERS and etc instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add CORS to the Version Mismatch Server.