[ISSUE #34910] add headers to HttpResponse for test framework #35105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
artem1205
approved these changes
Feb 9, 2024
maxi297
deleted the
issue-34910/add-headers-to-http-response-for-test-framework
branch
natikgadzhi
reviewed
Feb 10, 2024
| @@ -60,7 +60,9 @@ def _mock_request_method( | |||
| getattr(self._mocker, method)( | |||
| requests_mock.ANY, | |||
| additional_matcher=self._matches_wrapper(matcher), | |||
| response_list=[{"text": response.body, "status_code": response.status_code} for response in responses], | |||
| response_list=[ | |||
There was a problem hiding this comment.
Curious: what formatter are you using, and do we have centralized enforced formatting / linting yet?
There was a problem hiding this comment.
I blindly use airbyte-ci format fix all
xiaohansong
pushed a commit
that referenced
this pull request
Feb 13, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 21, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
xiaohansong
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addresses #34910
How
Add headers that are empty dict by default and allow to user to optionally provide them
🚨 User Impact 🚨
Will unblock #34933 (comment) and allow future users to add headers to responses