✨ source-facebook-marketing: migrate to poetry - #35178
Merged
Octavia The Approver (octavia-approvington) merged 2 commits intoFeb 12, 2024
Merged
✨ source-facebook-marketing: migrate to poetry#35178Octavia The Approver (octavia-approvington) merged 2 commits into
Octavia The Approver (octavia-approvington) merged 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Octavia Squidington IV (octavia-squidington-iv)
requested a review
from a team
February 12, 2024 15:23
Contributor
Author
|
/approve-and-merge reason="poetry migration. green ci." |
Contributor
Octavia The Approver (octavia-approvington)
approved these changes
Feb 12, 2024
Octavia The Approver (octavia-approvington)
deleted the
source-facebook-marketing-poetry
branch
February 12, 2024 18:05
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 13, 2024
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Relates to #34958
We want to make our connectors use
poetryfor dependency management (see tech spec)This PR is migrating
source-facebook-marketingtopoetry.How
pyproject.tomlandpoetry.locksetup.py