Skip to content

Destination snowflake: reorder auth spec options - #35194

Merged
Edward Gao (edgao) merged 2 commits into
masterfrom
edgao/snowflake/default_auth
Feb 13, 2024
Merged

Edward Gao (edgao) merged 2 commits into
masterfrom
edgao/snowflake/default_auth

Conversation

@edgao

@edgao Edward Gao (edgao) commented Feb 12, 2024 •

Copy link
Copy Markdown
Contributor

https://airbytehq-team.slack.com/archives/C03C4AVJWG4/p1707781669791419?thread_ts=1707774340.370569&cid=C03C4AVJWG4

confirmed locally that the config now defaults to private key, and user/pass is second in the list
image

@vercel

vercel Bot commented Feb 12, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 11:55pm

@github-actions

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Feb 12, 2024
@edgao
Edward Gao (edgao) marked this pull request as ready for review February 12, 2024 23:51
@edgao
Edward Gao (edgao) requested a review from a team as a code owner February 12, 2024 23:51
@edgao
Edward Gao (edgao) merged commit b262c00 into master Feb 13, 2024
@edgao
Edward Gao (edgao) deleted the edgao/snowflake/default_auth branch February 13, 2024 00:14

This branch was successfully deployed

1 active deployment
Preview — 4b9c55dc Deployed Feb 12, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/snowflake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants