[Source-Postgres] : Add config to throw an error on invalid CDC position - #35304
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Contributor
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
Akash Kulkarni (akashkulk)
changed the title
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Akash Kulkarni (akashkulk)
changed the title
Akash Kulkarni (akashkulk)
marked this pull request as ready for review
February 15, 2024 21:42
Akash Kulkarni (akashkulk)
requested a review
from Xiaohan Song (xiaohansong)
February 15, 2024 21:42
Marius Posta (postamar)
approved these changes
Feb 15, 2024
| AirbyteTraceMessageUtility.emitAnalyticsTrace(cdcCursorInvalidMessage()); | ||
| if (!sourceConfig.get("replication_method").has(INVALID_CDC_CURSOR_POSITION_PROPERTY) || sourceConfig.get("replication_method").get( | ||
| INVALID_CDC_CURSOR_POSITION_PROPERTY).asText().equals(FAIL_SYNC_OPTION)) { | ||
| throw new ConfigErrorException("Saved offset it before replication slot's confirmed lsn. Please increase WAL retention or reduce sync frequency. See https://docs.airbyte.com/integrations/sources/postgres/postgres-troubleshooting#under-cdc-incremental-mode-there-are-still-full-refresh-syncs for more details."); |
Contributor
There was a problem hiding this comment.
typo, s/Saved offset it/Saved offset is/
Xiaohan Song (xiaohansong)
approved these changes
Feb 15, 2024
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add config to throw an error on invalid CDC position.
Default behavior is to fail the sync. Option added to enable it as well. https://github.com/airbytehq/airbyte-internal-issues/issues/2886