-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page specific head title #3526
Conversation
Hmm, even though I have assigned the reviewers, the assign bot always tries to add two new people. This PR probably does not require that many pairs of eyes. |
@tuliren feel free to remove people that you don't think are required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't speak to the TS, but this is a great idea for the UI.
Only comment would be perhaps using a •
instead of a |
to separate subpages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have few questions, but in common looks fine. Awesome work!
Fair enough! There is ASCII 250 which serves the same purpose, but the pipe is totally fine, just a stylistic suggestion. |
What
How
Helmet
is used to update HTML head title in each page.Pre-merge Checklist
Recommended reading order
HeadTitle.tsx
┆Issue is synchronized with this Asana task by Unito