Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏥Source Klaviyo: fix version in pyproject.toml #35626

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

askarpets
Copy link
Contributor

What

Update version in pyproject.toml file to match what is in metadata.yaml, update expected records for the metrics stream

Recommended reading order

  1. pyproject.toml

🚨 User Impact 🚨

No breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@askarpets askarpets self-assigned this Feb 26, 2024
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Feb 26, 2024 10:04am

@lazebnyi
Copy link
Collaborator

/approve-and-merge reason="CI tests failed because the version was not incremented other tests passed. This change is minor with fix for connector version in pyproject file + expected records and can be safely merged."

@octavia-approvington
Copy link
Contributor

Check that box
TODO complete

@octavia-approvington octavia-approvington merged commit 7c11ea7 into master Feb 26, 2024
30 of 32 checks passed
@octavia-approvington octavia-approvington deleted the source-klaviyo-fix-version branch February 26, 2024 13:53
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants