Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old Java integration test from Stripe Singer source. #3621

Merged

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented May 26, 2021

What

Remove older java integration test from stripe-singer. These have been superceded by the python standard source test file.

…n superceded by the python standard source test file.
@davinchia davinchia requested a review from sherifnada May 26, 2021 07:27
@davinchia
Copy link
Contributor Author

@sherifnada does this seem sane?

@davinchia davinchia marked this pull request as ready for review May 26, 2021 07:27
@sherifnada
Copy link
Contributor

@davinchia we should nuke the whole source. It's no longer in use

@davinchia
Copy link
Contributor Author

@sherifnada great news! I love deleting code. Done.

@davinchia davinchia merged commit e0480ab into master May 26, 2021
@davinchia davinchia deleted the davinchia/remove-old-java-integration-test-from-stripe branch May 26, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants