Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Iterable: Migrate to low code #36231

Merged
merged 16 commits into from
Apr 15, 2024
Merged

✨Source Iterable: Migrate to low code #36231

merged 16 commits into from
Apr 15, 2024

Conversation

lazebnyi
Copy link
Collaborator

@lazebnyi lazebnyi commented Mar 18, 2024 •
edited
Loading

What

Fixed https://github.com/airbytehq/airbyte-internal-issues/issues/6426

How

  • Migrated Source Iterable to Declarative Source
  • Removed AccessCheck as we check connection with List stream
  • Removed custom all_streams_accessible validation during check connection, instead used default availability logic

Recommended reading order

  1. x.yaml
  2. y.python

🚨 User Impact 🚨

No

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 2:19pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/iterable labels Mar 18, 2024
@lazebnyi lazebnyi requested a review from a team March 18, 2024 12:56
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 20, 2024 23:26
@clnoll clnoll self-requested a review March 21, 2024 18:07
clnoll
clnoll reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lazebnyi I've left a few initial comments and questions for you. Let me know when it's ready for another look!

airbyte-integrations/connectors/source-iterable/source_iterable/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-iterable/source_iterable/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-iterable/source_iterable/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-iterable/unit_tests/test_extractors.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-iterable/unit_tests/test_stream_events.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-iterable/unit_tests/test_source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-iterable/source_iterable/manifest.yaml Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-iterable/unit_tests/test_streams.py Show resolved Hide resolved
@alafanechere alafanechere added the low-code-migration This connector has been migrated to the low-code CDK label Mar 22, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 22, 2024 17:17
@lazebnyi lazebnyi requested a review from clnoll March 22, 2024 19:17
clnoll
clnoll reviewed Mar 23, 2024
View reviewed changes
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @lazebnyi! Let me know when you've had the chance to run regression tests and I'll approve.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team March 23, 2024 00:24
@lazebnyi lazebnyi changed the title Source Iterable: Migrate to low code ✨Source Iterable: Migrate to low code Mar 27, 2024
@lazebnyi lazebnyi requested a review from clnoll April 2, 2024 00:59
@lazebnyi lazebnyi merged commit 0c49832 into master Apr 15, 2024
29 checks passed
@lazebnyi lazebnyi deleted the lazebnyi/6426-source-iterable-to-low-code branch April 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clnoll clnoll clnoll approved these changes

Assignees

@clnoll clnoll

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/iterable low-code-migration This connector has been migrated to the low-code CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lazebnyi @clnoll @alafanechere @octavia-squidington-iii