Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-paypal-transaction: ensure inline schemas, updated cdk, poetry (where possible) #36654

Merged

Conversation

bleonard
Copy link
Contributor

@bleonard bleonard commented Mar 29, 2024

This was created from a set of automated scripts. In each case, not every update was needed for every connector, but overall here is what happened:

  • auto-schema update -s all description: added descriptions to json and inline schemas
  • connector-code migrate_to_yaml -c all --type source: migrates json schemas to connectors with a manifest
  • airbyte-ci connectors --name=<all modified connectors from above> migrate_to_base_image: makes sure that each is using a base docker image and updates docs
  • airbyte-ci connectors --name=<all modified connectors from above> migrate-to-poetry: moves connectors not already using poetry to do so and updates documentation
  • airbyte-ci connectors --name=<all modified connectors from above> up_to_date: updated the CDK to newer (0.80.0) version

The version number and changelogs were also bumped using the connector-code pulls command.

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 10:34am

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Connector version increment check freaks out, but this is fine. Good to merge in the morning.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 13, 2024
@bleonard bleonard changed the title source-paypal-transaction: schema descriptions source-paypal-transaction: ensure inline schemas, updated cdk, poetry (where possible) Apr 20, 2024
@bleonard
Copy link
Contributor Author

Seems likely there were other updates on the master branch. Have to mess around with the version probably.

@bazarnov
Copy link
Collaborator

@bleonard I was able to bump the CDK version last week for the source-paypal, re-base and merge with master, should resolve the conflicts.

@bleonard
Copy link
Contributor Author

rebased!

@bleonard bleonard force-pushed the autopull/schema-descriptions-d2a8da/source-paypal-transaction branch from 24b1f77 to e8cf1da Compare April 25, 2024 05:56
@@ -17,7 +17,7 @@ include = "source_paypal_transaction"

[tool.poetry.dependencies]
python = "^3.9,<3.12"
airbyte-cdk = "^0"
airbyte-cdk = "0.82.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we pin the versions again?

@lazebnyi lazebnyi merged commit 86ee370 into master May 7, 2024
34 checks passed
@lazebnyi lazebnyi deleted the autopull/schema-descriptions-d2a8da/source-paypal-transaction branch May 7, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation autopull connectors/source/paypal-transaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants