source-salesforce: ensure inline schemas, updated cdk, poetry (where possible) #36657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
bleonard
changed the title
maxi297
reviewed
Apr 25, 2024
| @@ -18,7 +18,7 @@ include = "source_salesforce" | |||
| [tool.poetry.dependencies] | |||
| python = "^3.9,<3.12" | |||
| pandas = "2.2.1" | |||
| airbyte-cdk = "^0" | |||
| airbyte-cdk = "0.83.1" | |||
There was a problem hiding this comment.
Why upper bound this to 0.83.1?
There was a problem hiding this comment.
Same question for the rest of the PR's like this one.
maxi297
approved these changes
Apr 29, 2024
ChristoGrab
deleted the
autopull/schema-descriptions-d2a8da/source-salesforce
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was created from a set of automated scripts. In each case, not every update was needed for every connector, but overall here is what happened:
auto-schema update -s all description: added descriptions to json and inline schemasconnector-code migrate_to_yaml -c all --type source: migrates json schemas to connectors with a manifestairbyte-ci connectors --name=<all modified connectors from above> migrate_to_base_image: makes sure that each is using a base docker image and updates docsairbyte-ci connectors --name=<all modified connectors from above> migrate-to-poetry: moves connectors not already using poetry to do so and updates documentationairbyte-ci connectors --name=<all modified connectors from above> up_to_date: updated the CDK to newer (0.80.0) versionThe version number and changelogs were also bumped using the
connector-code pullscommand.