source-coda: Replace use of last_records with last_record #36775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
girarda
changed the title
girarda
commented
Apr 3, 2024
| @@ -53,7 +53,7 @@ definitions: | |||
| type: "DefaultPaginator" | |||
| pagination_strategy: | |||
| type: "CursorPagination" | |||
| cursor_value: "{{ last_records['href'] }}" | |||
| cursor_value: "{{ last_record['href'] }}" | |||
There was a problem hiding this comment.
I'm not sure how this was meant to work. last_records is an array, not a dict
girarda
commented
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update source-coda to stop using
last_recordsinterpolation variable as it is being deprecated.Also upgrade to base image and poetry
Results from regression tests:
