Postgres: column name truncation spike #36805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
jbfbell
reviewed
Apr 3, 2024
| @@ -161,6 +161,45 @@ constructor( | |||
| var i = 1 | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
done in c610197?w=1. also cleaned up some of the kotlin autoconvert cruft.
jbfbell
approved these changes
Apr 3, 2024
gisripa
reviewed
Apr 3, 2024
| // but this interface + our superclass are weirdly complicated, so plausibly something is missing | ||
| @Override | ||
| public String getIdentifier(final String name) { | ||
| return truncate(super.getIdentifier(name)); |
There was a problem hiding this comment.
I already made another mess here unify that with call to getIdentifier ?
gisripa
force-pushed
the
gireesh/03-28-postgres-cdkk-fixes
branch
8 times, most recently
from
3ca93b5
to
5bbae1f
Compare
edgao
force-pushed
the
edgao/postgres_column_name_truncation
branch
from
c1204a2
to
f29d835
Compare
gisripa
force-pushed
the
gireesh/03-28-postgres-cdkk-fixes
branch
2 times, most recently
from
7ddd15b
to
f2bf8e0
Compare
edgao
force-pushed
the
edgao/postgres_column_name_truncation
branch
from
8291ba5
to
74dde57
Compare
|
/publish-java-cdk
|
octavia-squidington-iii
added
the
area/documentation
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacked on #36620.
See also #36808 for "just throw an error".we end up with e.g.
ddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd(63 chars long) andddddddddddddddddddddddddddddd461dddddddddddddddddddddd_rirqs2(note the461in the middle), when the original column names ared<510>d_rirqs1andd<510>d_rirqs2. Not convinced this is actually great behavior.also, fix the catalogparser tests to have more stringent asserts. Previously they were actually just completely useless, because we were mocking the wrong method. The asserts should now catch this problem, since we assert on the actual table/column names.
submitted https://github.com/airbytehq/airbyte-internal-issues/issues/6989 to make collision logic better in general.