-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Python CDK: change minimum python version to 3.7.0 #3692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job looking for & updating the relevant docs. A couple more things we need to do to ensure that this works correctly:
- change
.github/workflows/publish-cdk.yaml
to use python 3.7.0 so we can test that this works correctly on the advertised version - bump the CDK version in setup.py
- Using a version manager like pyenv verify that the tests work locally on this python version. You can run tests using
./type_check_and_test.sh
- if all looks good, push and comment
/publish-cdk
to do a dry run - if it succeeds publish with
dry-run=false
to publish to actual CDK - Update the changelog and follow any other steps in our DoD
- merge this PR
PS: this should have gone to internal review first, but it LGTM so no worries 🙂
/publish-cdk
|
/publish-cdk
|
I see that python |
/publish-cdk
|
/publish-cdk dry-run=false
|
What
#3578 Allow Python CDK to work with Python 3.7.X
How
Updated python version in
setup.py
Pre-merge Checklist
Recommended reading order
setup.py