Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Python CDK: change minimum python version to 3.7.0 #3692

Merged
merged 9 commits into from
May 28, 2021

Conversation

yaroslav-dudar
Copy link
Contributor

@yaroslav-dudar yaroslav-dudar commented May 28, 2021

What

#3578 Allow Python CDK to work with Python 3.7.X

How

Updated python version in setup.py

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. setup.py

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job looking for & updating the relevant docs. A couple more things we need to do to ensure that this works correctly:

  1. change .github/workflows/publish-cdk.yaml to use python 3.7.0 so we can test that this works correctly on the advertised version
  2. bump the CDK version in setup.py
  3. Using a version manager like pyenv verify that the tests work locally on this python version. You can run tests using ./type_check_and_test.sh
  4. if all looks good, push and comment /publish-cdk to do a dry run
  5. if it succeeds publish with dry-run=false to publish to actual CDK
  6. Update the changelog and follow any other steps in our DoD
  7. merge this PR

PS: this should have gone to internal review first, but it LGTM so no worries 🙂

@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented May 28, 2021

/publish-cdk

https://github.com/airbytehq/airbyte/actions/runs/884853448

@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented May 28, 2021

/publish-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/884910607
https://github.com/airbytehq/airbyte/actions/runs/884910607

@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented May 28, 2021

/publish-cdk

https://github.com/airbytehq/airbyte/actions/runs/885099020

@yaroslav-dudar
Copy link
Contributor Author

I see that python 3.7.0 is not available in actions/setup-python@v2 . There is 3.7.1 but not 3.7.0 https://github.com/actions/python-versions/blob/main/versions-manifest.json

@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented May 28, 2021

/publish-cdk

https://github.com/airbytehq/airbyte/actions/runs/885289932

@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented May 28, 2021

/publish-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/885335241
https://github.com/airbytehq/airbyte/actions/runs/885335241

@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented May 28, 2021

/publish-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/885367416
https://github.com/airbytehq/airbyte/actions/runs/885367416

@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented May 28, 2021

/publish-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/885476941
https://github.com/airbytehq/airbyte/actions/runs/885476941

@yaroslav-dudar
Copy link
Contributor Author

yaroslav-dudar commented May 28, 2021

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/886373630
https://github.com/airbytehq/airbyte/actions/runs/886373630

@yaroslav-dudar yaroslav-dudar merged commit c49ff40 into master May 28, 2021
@yaroslav-dudar yaroslav-dudar deleted the yaroslav-dudar/3578 branch May 28, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants