Small fixes to python cdk publishing #36945
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
the
area/documentation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @erohmensing and the rest of your teammates on |
| run: | | ||
| cd airbyte-integrations/connectors/source-declarative-manifest | ||
| # --no-cache is used to ensure the latest version is fetched. Let's see if we need to add a wait... | ||
| poetry add airbyte-cdk==${{needs.bump-version.outputs.new_cdk_version}} --no-cache | ||
| while true; do |
There was a problem hiding this comment.
This seems very odd. If it fails, will there be a good error message to indicate the failure?
There was a problem hiding this comment.
If it continues to fail, the github action will timeout. Then we will get the standard slack error message of us not being able to update the source-declarative-manifest version
Are you worried about it failing to actually add the dependency (compared to if it can't resolve it in time)?
There was a problem hiding this comment.
I guess the latter. Like, I don't understand why with pip we were fine and now we need this. When it feels, it would be nice to have an actionnable error message
There was a problem hiding this comment.
Ah I see! manage.sh took over 5 minutes of processing before getting to the "install the newly published version of the cdk into the docker image" step of the job that happened directly after the cdk publish to pypi step. This gave it time to become available.
This job by comparison gets to the installation step in 42 seconds after the publish job, which doesn't seem to be quite enough time (sometimes).
There was a problem hiding this comment.
The output of both the failures and the successes shoudl still print to the GHA logs. I'll add an echo about the retry to make it make more sense
Merge activity
|
source-declarative-manifestcannot be published