Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source My Hours: Migrate Python CDK to Low-code CDK #36947

Merged
merged 26 commits into from
Apr 16, 2024
Merged

✨Source My Hours: Migrate Python CDK to Low-code CDK #36947

merged 26 commits into from
Apr 16, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

Migrating Source My Hours to Low-Code CDK
Closes airbytehq/airbyte-internal-issues#6755

How

Developed using (Configuration Based Source) low-code CDK

Recommended reading order

  1. spec.yaml
  2. manifest.yaml
  3. schemas/*

Tests

Integration & Acceptance Full Test Results using Poetry

image

🚨 User Impact 🚨

  • Spec Breaking changes, migration to low-code

btkcodedev and others added 25 commits March 14, 2024 21:48
@btkcodedev
Source My Hours: Migrate Python CDK to Low Code CDK
6d77099
@btkcodedev
chore: Update version, docs: update documentation
5498a70
@btkcodedev
Merge branch 'master' into feat/myhoursLowcode
ea3bf7b
@btkcodedev
fix: export manifest file directly from builder, change spec, update …
5fe5247 
…docs
@btkcodedev
Merge branch 'feat/myhoursLowcode' of https://github.com/btkcodedev/a…
74a17a9 
…irbyte into feat/myhoursLowcode
@btkcodedev
Merge branch 'master' into feat/myhoursLowcode
2f08b7d
@btkcodedev
Merge branch 'master' into feat/myhoursLowcode
0adef90
@btkcodedev
fix: Add pyproject.toml, fix: schemas, format: manifest.yaml, retest:…
92b4e4a 
… all passed
@btkcodedev
Merge branch 'feat/myhoursLowcode' of https://github.com/btkcodedev/a…
c5d76f3 
…irbyte into feat/myhoursLowcode
@btkcodedev
fix: pyproject.toml file path
61d023b
@btkcodedev
Merge branch 'master' into feat/myhoursLowcode
9972c9e
@btkcodedev
chore: update metadata version, update docs
ff5373b
@btkcodedev
Merge branch 'feat/myhoursLowcode' of https://github.com/btkcodedev/a…
b970f0b 
…irbyte into feat/myhoursLowcode
@btkcodedev
Merge branch 'master' into feat/myhoursLowcode
17b9938
@btkcodedev @girarda
Update airbyte-integrations/connectors/source-my-hours/source_my_hour…
09a390a 
…s/__init__.py

Co-authored-by: Alexandre Girard <alexandre@airbyte.io>
@btkcodedev
Merge branch 'master' into feat/myhoursLowcode
83c0c44
@btkcodedev
feat: Suppport email:password auth type
96702e1
@btkcodedev
Merge branch 'master' into feat/myhoursLowcode
4679eda
@btkcodedev
revert date
3893a34
@btkcodedev
fix: include backward compatability tests
e3067bc
@btkcodedev
Add migrations.md and poetry.lock
e2a1f10
@btkcodedev
Merge branch 'master' into feat/myhoursLowcode
6ceec68
@btkcodedev
update docs, move schemas inline, update poetry lock, metadata
c391b34
@btkcodedev
Merge branch 'master' into feat/myhoursLowcode
f1be2bf
@btkcodedev
Merge remote-tracking branch 'fork/feat/myhoursLowcode' into btkcoded…
26e8757 
…ev/myhoursLowCode
@btkcodedev btkcodedev added the low-code-migration This connector has been migrated to the low-code CDK label Apr 10, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 5:16am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 10, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team April 10, 2024 05:08
@octavia-squidington-iv octavia-squidington-iv requested a review from a team April 10, 2024 05:08
@btkcodedev
Copy link
Collaborator Author

Inline Schema ✅
Poetry lock file ✅
No breaking change ✅
Docs updated ✅

Test results: All pass
image

@btkcodedev
Copy link
Collaborator Author

Marking PR ready for merge

@btkcodedev btkcodedev mentioned this pull request Apr 10, 2024
Closed
@lazebnyi lazebnyi self-requested a review April 10, 2024 13:44
@lazebnyi lazebnyi self-assigned this Apr 11, 2024
lazebnyi
lazebnyi approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All regressions tests passed successfully, except test_catalog_are_the_same. But with manual tests have founded that catalog changed just with null types and additionalProperties field.

LGTM

@lazebnyi lazebnyi merged commit 653113b into master Apr 16, 2024
31 of 33 checks passed
@lazebnyi lazebnyi deleted the btkcodedev/myhoursLowCode branch April 16, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees

@lazebnyi lazebnyi

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/my-hours low-code-migration This connector has been migrated to the low-code CDK team/connectors-python team/extensibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btkcodedev @lazebnyi @octavia-squidington-iii