remove testing attribute from telemetry #36995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to ef3c4b0
- Looked at
13lines of code in1files - Took 38 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. run-ab-platform.sh:149:
- Assessed confidence :
50% - Comment:
The 'testing' attribute has been removed. Please ensure that this attribute is not used elsewhere in the codebase. - Reasoning:
The PR removes the 'testing' attribute from the telemetry data. This attribute was hardcoded to 'true' in the original code. The removal of this attribute should not cause any issues if it is not used elsewhere in the codebase. I will check the codebase to confirm this.
Workflow ID: wflow_hyqDuf6l0cHJog0X
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see title
Summary:
This PR removes the
testingattribute from the telemetry data sent by therun-ab-platform.shscript.Key points:
testingattribute fromTelemetrySendfunction inrun-ab-platform.shGenerated with ❤️ by ellipsis.dev