Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Azure Blob Storage: add unit tests #37467

Merged
merged 11 commits into from
Apr 28, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Apr 22, 2024

What

Resolving https://github.com/airbytehq/airbyte-internal-issues/issues/6831

How

  • add unit tests to increase coverage up to 90%+.
  • filter files by start date

Review guide

  1. airbyte-integrations/connectors/source-azure-blob-storage/unit_tests/test_authenticator.py
  2. airbyte-integrations/connectors/source-azure-blob-storage/unit_tests/test_stream_reader.py
  3. airbyte-integrations/connectors/source-azure-blob-storage/unit_tests/test_config_migration.py

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 self-assigned this Apr 22, 2024
Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 9:20pm

[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 merged commit abba3a7 into master Apr 28, 2024
33 checks passed
@artem1205 artem1205 deleted the artem1205/source-azure-blob-storage-cert branch April 28, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants