fix kotlin warnings in CDK core #37477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
force-pushed
the
stephane/04-22-fix_kotlin_warnings_in_cdk_core
branch
from
2b42c18
to
f703678
Compare
postamar
reviewed
Apr 23, 2024
| @@ -332,8 +332,10 @@ abstract class AbstractJdbcCompatibleSourceOperations<Datatype> : | |||
| } | |||
| } | |||
|
|
|||
| // Note: I'm guessing this is an open function, since it doesn't do anything here, and doesn't | |||
| // override anything either | |||
There was a problem hiding this comment.
I can answer that: all these methods should be open
There was a problem hiding this comment.
I think they should be abstract. I really don't like optional methods. Battle for another day though
postamar
reviewed
Apr 23, 2024
| @@ -17,7 +17,7 @@ import org.slf4j.LoggerFactory | |||
| /** Implementation of source operations with standard JDBC types. */ | |||
| open class JdbcSourceOperations : | |||
| AbstractJdbcCompatibleSourceOperations<JDBCType>(), SourceOperations<ResultSet, JDBCType> { | |||
| protected fun safeGetJdbcType(columnTypeInt: Int): JDBCType { | |||
| private fun safeGetJdbcType(columnTypeInt: Int): JDBCType { | |||
There was a problem hiding this comment.
This probably needs to be open protected as well, but I'm less sure.
postamar
reviewed
Apr 23, 2024
| @@ -256,7 +251,7 @@ internal constructor( | |||
| messageIterator: AutoCloseableIterator<AirbyteMessage>, | |||
| recordCollector: Consumer<AirbyteMessage> | |||
| ) { | |||
| messageIterator!!.airbyteStream.ifPresent { s: AirbyteStreamNameNamespacePair? -> | |||
| messageIterator.airbyteStream.ifPresent { s: AirbyteStreamNameNamespacePair? -> | |||
There was a problem hiding this comment.
s need not be nullable. Comment applies elsewhere also.
There was a problem hiding this comment.
will need another pass
postamar
approved these changes
Apr 23, 2024
stephane-airbyte
force-pushed
the
stephane/04-22-fix_kotlin_warnings_in_cdk_core
branch
3 times, most recently
from
e10a324
to
5fc346d
Compare
stephane-airbyte
force-pushed
the
stephane/04-22-fix_kotlin_warnings_in_cdk_core
branch
from
5fc346d
to
4d64c8f
Compare
stephane-airbyte
deleted the
stephane/04-22-fix_kotlin_warnings_in_cdk_core
branch
strosek
pushed a commit
that referenced
this pull request
Apr 24, 2024
just fixing kotlin warnings in CDK Interesting tidbit: Because of named parameters, it's important that a function override has the same parameter names as the overriden function. Hence some parameter renaming here. Also, variable name shadowing is reported as a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just fixing kotlin warnings in CDK
Interesting tidbit: Because of named parameters, it's important that a function override has the same parameter names as the overriden function. Hence some parameter renaming here.
Also, variable name shadowing is reported as a warning