fix kotlin warnings in azure-destination, datastore-{bigquery,mongo,postgres} CDK submodules #37479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ostgres} CDK submodules
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
postamar
reviewed
Apr 23, 2024
| @@ -47,16 +47,18 @@ abstract class AzureBlobStorageStreamCopier( | |||
| ) | |||
| protected val azureStagingFiles: MutableSet<String> = HashSet() | |||
|
|
|||
| @get:VisibleForTesting val tmpTableName: String = nameTransformer.getTmpTableName(streamName) | |||
| @Suppress("DEPRECATION") | |||
| @get:VisibleForTesting | |||
There was a problem hiding this comment.
Curious if these annotations are still relevant in kotlin. I know it's for the benefit of the findbugs linter, but perhaps making these internal instead are the way to go?
There was a problem hiding this comment.
haven't looked at that. Was focusing on kotlin warnings
There was a problem hiding this comment.
those are all over the place. Will need another pass for that :(
postamar
reviewed
Apr 23, 2024
| .setType(StandardSQLTypeName.STRING) | ||
| .build() | ||
| } | ||
| .collect(Collectors.toList()) |
There was a problem hiding this comment.
params.map { ... }.toList()
postamar
approved these changes
Apr 23, 2024
stephane-airbyte
deleted the
stephane/04-22-fix_kotlin_warnings_in_azure-destination_datastore-_bigquery_mongo_postgres_cdk_submodules
branch
strosek
pushed a commit
that referenced
this pull request
Apr 24, 2024
…ostgres} CDK submodules (#37479) cleaning kotlin warnings in some CDK submodules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaning kotlin warnings in some CDK submodules