allow "java" connectors to be written in kotlin #37485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
stephane-airbyte
requested review from
alafanechere
and removed request for
a team
alafanechere
approved these changes
Apr 24, 2024
stephane-airbyte
force-pushed
the
stephane/04-22-allow_java_connectors_to_be_written_in_kotlin
branch
from
6ea1b08
to
ea34d15
Compare
stephane-airbyte
deleted the
stephane/04-22-allow_java_connectors_to_be_written_in_kotlin
branch
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, we don't allow java connectors to be written in kotlin. We could add a new language KOTLIN, but since all the targets are the same, it seems overkill. So i'm just changing the condition for language=JAVA