✨ Source dynamodb: Allow role based access #37530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
keiththompson
force-pushed
the
keith/dynamodb_role_based_access
branch
from
f5d43e2
to
ccb1879
Compare
octavia-squidington-iii
added
the
area/documentation
marcosmarxm
requested changes
Apr 24, 2024
...rs/source-dynamodb/src/main/java/io/airbyte/integrations/source/dynamodb/DynamodbConfig.java
Outdated
Show resolved
Hide resolved
...ors/source-dynamodb/src/main/java/io/airbyte/integrations/source/dynamodb/DynamodbUtils.java
Show resolved
Hide resolved
airbyte-integrations/connectors/source-dynamodb/src/main/resources/spec.json
Show resolved
Hide resolved
marcosmarxm
temporarily deployed
to
community-ci
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci
GitHub Actions
Inactive
marcosmarxm
temporarily deployed
to
community-ci
GitHub Actions
Inactive
marcosmarxm
requested changes
Apr 29, 2024
airbyte-integrations/connectors/source-dynamodb/src/main/resources/spec.json
Show resolved
Hide resolved
...rs/source-dynamodb/src/main/java/io/airbyte/integrations/source/dynamodb/DynamodbConfig.java
Outdated
Show resolved
Hide resolved
keiththompson
force-pushed
the
keith/dynamodb_role_based_access
branch
from
99aa2c5
to
1994b84
Compare
keiththompson
had a problem deploying
to
community-ci
GitHub Actions
Error
keiththompson
force-pushed
the
keith/dynamodb_role_based_access
branch
from
1994b84
to
265823f
Compare
keiththompson
had a problem deploying
to
community-ci
GitHub Actions
Error
keiththompson
had a problem deploying
to
community-ci
GitHub Actions
Error
|
@marcosmarxm Thanks for your review - I've updated the PR to reflect the changes requested. |
keiththompson
force-pushed
the
keith/dynamodb_role_based_access
branch
from
8db8ab7
to
c4cf7b5
Compare
keiththompson
had a problem deploying
to
community-ci
GitHub Actions
Error
keiththompson
had a problem deploying
to
community-ci
GitHub Actions
Error
keiththompson
temporarily deployed
to
community-ci
GitHub Actions
Inactive
keiththompson
temporarily deployed
to
community-ci
GitHub Actions
Inactive
marcosmarxm
requested changes
Apr 30, 2024
airbyte-integrations/connectors/source-dynamodb/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-dynamodb/src/main/resources/spec.json
Show resolved
Hide resolved
airbyte-integrations/connectors/source-dynamodb/src/main/resources/spec.json
Show resolved
Hide resolved
keiththompson
had a problem deploying
to
community-ci
GitHub Actions
Error
keiththompson
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
keiththompson
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
keiththompson
had a problem deploying
to
community-ci
GitHub Actions
Failure
|
Hi @marcosmarxm - I've updated the spec based on your comments. Thanks again. |
marcosmarxm
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Support role based access for DynamoDb connector. As a security principal, it is good to avoid using long living AWS Users. Role based access means you do not need to keep rotating user credentials.
https://medium.com/datamindedbe/why-you-should-not-use-iam-users-d0368dd319d3
How
By making access_key and secret_access_key optional in the config spec, we can fallback to using the DefaultCredentialsProvider if they're not provided. Anybody currently using access_key and secret_access_key will continue to use those credentials, so I've avoided a breaking change.
Review guide
airbyte-integrations/connectors/source-dynamodb/src/main/resources/spec.jsonairbyte-integrations/connectors/source-dynamodb/src/main/java/io/airbyte/integrations/source/dynamodb/DynamodbConfig.javaairbyte-integrations/connectors/source-dynamodb/src/main/java/io/airbyte/integrations/source/dynamodb/DynamodbUtils.javaUser Impact
Role based access is now possible.
Can this PR be safely reverted and rolled back?