Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(live-test): Update Readme #37634

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Apr 26, 2024

TL;DR

Updated Readme for live-test after using it for the first time

What changed?

  • Removed --connection-id from examples (since its automatic now)
  • Added lints to Loom walkthrough and internal docs
  • Updated CLI arguments for custom configurations

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 4:05pm

Copy link
Contributor Author

bnchrch commented Apr 26, 2024

@bnchrch bnchrch marked this pull request as ready for review April 26, 2024 17:05
@bnchrch bnchrch requested a review from a team as a code owner April 26, 2024 17:05
@bnchrch bnchrch force-pushed the 04-26-docs_live-test_update_readme branch from b4112c8 to 8092918 Compare April 26, 2024 18:11
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bnchrch!

@natikgadzhi
Copy link
Contributor

prettier --write it, please!

@bnchrch bnchrch force-pushed the 04-26-docs_live-test_add_descriptions_to_connection_objects branch from 0877561 to 317367b Compare April 29, 2024 15:33
Base automatically changed from 04-26-docs_live-test_add_descriptions_to_connection_objects to master April 29, 2024 16:04
@bnchrch bnchrch force-pushed the 04-26-docs_live-test_update_readme branch from 8092918 to 04136bb Compare April 29, 2024 16:05
Copy link
Contributor Author

bnchrch commented Apr 29, 2024

Merge activity

  • Apr 29, 12:06 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 29, 12:15 PM EDT: @bnchrch merged this pull request with Graphite.

@bnchrch bnchrch merged commit 3417fe8 into master Apr 29, 2024
33 checks passed
@bnchrch bnchrch deleted the 04-26-docs_live-test_update_readme branch April 29, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants