Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community-ci: declare "early CI" #37690

Merged

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Apr 30, 2024

What

We want to run some CI checks on community PRs automatically.
For safety reasons these checks would be the one which:

  • Do not require secrets
  • Do not require connector code execution

This PR makes the static checks (a.k.a qa checks) and version increment checks run automatically on community PRs.

How

  • Declare an "early CI" job in the community ci workflow
  • Run airbyte-ci connectors test --only-step=qa_checks --only-step=version_inc_check
  • Modify airbyte-ci to customize the name of the global status check that are emitted by a test command

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 7:26am

Copy link
Contributor Author

alafanechere commented Apr 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

Base automatically changed from augustin/04-30-airbyte-ci_format_make_most_inputs_optional_in_run-airbyte-ci to master April 30, 2024 15:42
@alafanechere alafanechere force-pushed the augustin/04-30-airbyte-ci_custom_CI_status_checks branch 2 times, most recently from 23e93da to 07d93cf Compare April 30, 2024 16:28
@alafanechere alafanechere changed the title airbyte-ci: custom CI status checks community-ci: declare "early CI" Apr 30, 2024
@alafanechere alafanechere marked this pull request as ready for review April 30, 2024 17:21
@alafanechere alafanechere requested a review from a team as a code owner April 30, 2024 17:21
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that we're improving, and I love pre-ci idea. Approving to move forward.

That said, two pieces of feedback I have for you are:

  • Please do not discard all PRs to CDK and to airbyte-ci. I don't think you have to do this. Perhaps we can only do this for pre-ci, but keep airbyte-ci directory from fork for full CI, so we get security, but keep ability to test airbyte-ci changes on demand with approval.
  • Ditto formatters, while separate PR, formatters should also run without priviledges and automatically without human approval I think.

id: pull_github_folder
run: |
git remote add main https://github.com/airbytehq/airbyte.git
git fetch main ${MAIN_BRANCH_NAME}
git checkout main/${MAIN_BRANCH_NAME} -- .github
git checkout main/${MAIN_BRANCH_NAME} -- airbyte-ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make it impossible to test any changes to airbyte-ci itself, and I don't think this is necessary.

@alafanechere
Copy link
Contributor Author

Please do not discard all PRs to CDK and to airbyte-ci. I don't think you have to do this. Perhaps we can only do this for pre-ci, but keep airbyte-ci directory from fork for full CI, so we get security, but keep ability to test airbyte-ci changes on demand with approval

I'm thinking of creating a different workflow for CDK and airbyte-ci contributions.
My plan is to restructure our workflow to reduce the number of workflow files to simplify maintainance and shared logic.

I'd ideally like to have:

  • A connector specific workflow which would run all required checks for connectors PRs, both on forks and not on forks
  • An internal packages specific workflow

@alafanechere alafanechere force-pushed the augustin/04-30-airbyte-ci_custom_CI_status_checks branch from 07d93cf to 092dac6 Compare May 2, 2024 07:25
@alafanechere alafanechere merged commit 4ef8db6 into master May 2, 2024
34 checks passed
@alafanechere alafanechere deleted the augustin/04-30-airbyte-ci_custom_CI_status_checks branch May 2, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants