-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community-ci: declare "early CI" #37690
community-ci: declare "early CI" #37690
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on Graphite |
23e93da
to
07d93cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love that we're improving, and I love pre-ci idea. Approving to move forward.
That said, two pieces of feedback I have for you are:
- Please do not discard all PRs to CDK and to airbyte-ci. I don't think you have to do this. Perhaps we can only do this for pre-ci, but keep airbyte-ci directory from fork for full CI, so we get security, but keep ability to test airbyte-ci changes on demand with approval.
- Ditto formatters, while separate PR, formatters should also run without priviledges and automatically without human approval I think.
id: pull_github_folder | ||
run: | | ||
git remote add main https://github.com/airbytehq/airbyte.git | ||
git fetch main ${MAIN_BRANCH_NAME} | ||
git checkout main/${MAIN_BRANCH_NAME} -- .github | ||
git checkout main/${MAIN_BRANCH_NAME} -- airbyte-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make it impossible to test any changes to airbyte-ci itself, and I don't think this is necessary.
I'm thinking of creating a different workflow for CDK and airbyte-ci contributions. I'd ideally like to have:
|
07d93cf
to
092dac6
Compare
What
We want to run some CI checks on community PRs automatically.
For safety reasons these checks would be the one which:
This PR makes the static checks (a.k.a qa checks) and version increment checks run automatically on community PRs.
How
airbyte-ci connectors test --only-step=qa_checks --only-step=version_inc_check