🐛 Source Monday: fetch display value when text is empty #37722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
tolik0
approved these changes
Apr 30, 2024
bazarnov
approved these changes
Apr 30, 2024
| datetime.strptime(result[item_index]["updated_at"], "%Y-%m-%dT%H:%M:%S%z").timestamp() | ||
| ) | ||
| for record in result: | ||
| if "updated_at" in record: |
There was a problem hiding this comment.
If this is the cursor value (updated_at) can we take it from the manifest or declare the constant otherwise?
There was a problem hiding this comment.
Frankly speaking - I'm not sure if this is a cursor value. There has been a change regarding the way we iterate the result, but nothing changed regarding this specific field. If you suggest declaring it as a constant, I'd prefer doing it in a separate PR
davydov-d
deleted the
ddavydov/source-monday-fetch-display-value-for-different-column-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://github.com/airbytehq/oncall/issues/4337
How
display_valuefield for three column types:Mirror,Dependency, andBoard connectiondisplay_valuefield andtextif it is emptyUser Impact
Only positive impact expected: for column types
Mirror,Dependency,Board connectionvalues should appear in thetextcolumn instead of empty stringsCan this PR be safely reverted and rolled back?